[rs-commit] r256 - /mod_ca/trunk/mod_ca_simple.c

[rs-commit at redwax.eu]

Author: dirkx at redwax.eu
Date: Wed Jan  8 14:47:01 2020
New Revision: 256

Log:
Move clear-error (as a non-existent algoritm does not actually set an error - so we get confusing cruft if it is not cleared.

Modified:
    mod_ca/trunk/mod_ca_simple.c

Modified: mod_ca/trunk/mod_ca_simple.c
==============================================================================
--- mod_ca/trunk/mod_ca_simple.c	(original)
+++ mod_ca/trunk/mod_ca_simple.c	Wed Jan  8 14:47:01 2020
@@ -1111,14 +1111,13 @@
 
     arg = apr_strtok(apr_pstrdup(cmd->pool, args), " \t", &tok);
 
+    ERR_clear_error();
     method = EVP_PKEY_asn1_find_str(NULL, arg, -1);
     if (!method) {
         return log_config(cmd,
                 apr_psprintf(cmd->pool,
                         "CASimpleAlgorithm '%s' was not found", arg));
     }
-
-    ERR_clear_error();
 
     EVP_PKEY_asn1_get0_info(&pkey_id, NULL, NULL, NULL, NULL, method);
     conf->pkey_ctx = EVP_PKEY_CTX_new_id(pkey_id, NULL);